Skip to content

ldiv! for Diagonal and a sparse vector #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2025
Merged

ldiv! for Diagonal and a sparse vector #613

merged 1 commit into from
Apr 7, 2025

Conversation

@jishnub
Copy link
Contributor

@jishnub jishnub commented Apr 4, 2025

This improves performance:

julia> using LinearAlgebra, SparseArrays

julia> D = Diagonal(rand(3000));

julia> S = sprand(size(D,1), 0.01);

julia> @btime ldiv!($D, $S);
  30.053 μs (0 allocations: 0 bytes) # master
  1.585 μs (0 allocations: 0 bytes) # PR

@codecov
Copy link

codecov bot commented Apr 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.11%. Comparing base (9548149) to head (476c33f).
Report is 9 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #613   +/-   ##
=======================================
  Coverage   84.10%   84.11%           
=======================================
  Files          12       12           
  Lines        9192     9189    -3     
=======================================
- Hits         7731     7729    -2     
+ Misses       1461     1460    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jishnub jishnub requested a review from ViralBShah April 6, 2025 15:58
@jishnub jishnub merged commit 4968cff into main Apr 7, 2025
10 checks passed
@jishnub jishnub deleted the jishnub/ldiv branch April 7, 2025 02:58
@ViralBShah ViralBShah added the backport 1.12 Change should be backported to release-1.12 label May 10, 2025
@dkarrasch dkarrasch added performance and removed backport 1.12 Change should be backported to release-1.12 labels May 11, 2025
dkarrasch pushed a commit that referenced this pull request May 11, 2025
@jishnub @dkarrasch
ldiv! for Diagonal and a sparse vector (#613)
2ae8768 
This improves performance:
```julia
julia> using LinearAlgebra, SparseArrays

julia> D = Diagonal(rand(3000));

julia> S = sprand(size(D,1), 0.01);

julia> @Btime ldiv!($D, $S);
  30.053 μs (0 allocations: 0 bytes) # master
  1.585 μs (0 allocations: 0 bytes) # PR
```
@dkarrasch dkarrasch mentioned this pull request May 11, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ViralBShah ViralBShah ViralBShah approved these changes

Assignees

No one assigned

Labels

performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jishnub @ViralBShah @dkarrasch